Skip to content

refactor(frontend): extract full-page loading screen controller (@hunterpaulson)#7697

Open
hunterpaulson wants to merge 1 commit intomonkeytypegame:masterfrom
hunterpaulson:feat/loading-screen-controller
Open

refactor(frontend): extract full-page loading screen controller (@hunterpaulson)#7697
hunterpaulson wants to merge 1 commit intomonkeytypegame:masterfrom
hunterpaulson:feat/loading-screen-controller

Conversation

@hunterpaulson
Copy link

Description

  • extract the full-page loading screen orchestration from page-controller into a dedicated loading-screen controller
  • update page-controller to use the extracted helper

Why

The full-page loading screen logic was previously embedded inside page-controller, which made it harder to reuse outside route transitions.
This refactor keeps the current behavior the same while moving the loading-screen orchestration into a dedicated controller so future non-routing flows (e.g. funboxes) can reuse the same loading UI without duplicating controller internals.

Validation

  • pnpm ts-check
  • pnpm lint-fast "src/ts/controllers/loading-screen.ts" "src/ts/controllers/page-controller.ts"
  • manually verified the extracted helper still shows the full-page loading screen with both bar and spinner modes

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 21, 2026
@fehmer
Copy link
Member

fehmer commented Mar 21, 2026

hi @hunterpaulson, thank you for your contribution.

Do you already have a use-case in mind?

@hunterpaulson
Copy link
Author

@fehmer yes, I’m working on a funbox that needs to do a second or two of initialization the first time it is selected, and I wanted to reuse the existing full-page progress bar for that flow instead of the LoaderBar that doesn't currently support progress.

@hunterpaulson hunterpaulson force-pushed the feat/loading-screen-controller branch from f9eedb8 to e5ba52f Compare March 22, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants