Skip to content

fix: stuck hover on focus for header and restart button (@byseif21) #7434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byseif21 wants to merge 10 commits into
base: master
Choose a base branch
from
+12 −10
Open

fix: stuck hover on focus for header and restart button (@byseif21) #7434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ba64b9d
fix: stuck hover on focus for header and restart button (@byseif21)
byseif21 Jan 23, 2026
584425e
cleanup
byseif21 Feb 27, 2026
b4a81dc
Merge branch 'master' into fix/stuck-hover
byseif21 Feb 27, 2026
d867a8f
fix keyboard nav
byseif21 Mar 3, 2026
c87df06
Merge branch 'master' into fix/stuck-hover
byseif21 Mar 3, 2026
596b00d
revert
byseif21 Mar 5, 2026
5835506
Merge branch 'master' into fix/stuck-hover
byseif21 Mar 5, 2026
40beb06
Merge branch 'master' into fix/stuck-hover
byseif21 Mar 5, 2026
ed559f6
fix? accountMenu is not static anymore, try starting a test while hov…
byseif21 Mar 5, 2026
68f8485
Merge branch 'master' into fix/stuck-hover
byseif21 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions frontend/src/styles/test.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,14 +1626,16 @@
}

main.focus .pageTest {
#testModesNotice {
opacity: 0 !important;
}
#testConfig {
#testModesNotice,
#testConfig,
#mobileTestConfigButton {
opacity: 0 !important;
}
#mobileTestConfigButton {
#restartTestButton {
opacity: 0 !important;
&:focus-visible {
opacity: 1 !important;
}
}
}

Expand Down
3 changes: 2 additions & 1 deletion frontend/src/ts/components/layout/header/Nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ export function Nav(): JSXElement {
<div
class={cn(
"relative",
"hover:**:data-[ui-element='accountMenu']:pointer-events-auto hover:**:data-[ui-element='accountMenu']:opacity-100",
!getFocus() &&
"hover:**:data-[ui-element='accountMenu']:pointer-events-auto hover:**:data-[ui-element='accountMenu']:opacity-100",
"has-focus-visible:**:data-[ui-element='accountMenu']:pointer-events-auto has-focus-visible:**:data-[ui-element='accountMenu']:opacity-100",
)}
>
Expand Down
7 changes: 3 additions & 4 deletions frontend/src/ts/test/focus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ let cache: {
function initializeCache(): void {
if (cacheReady) return;

const cursorSelector = "body, button, a";
const elementsSelector = [
"app",
"footer",
Expand All @@ -33,7 +32,6 @@ function initializeCache(): void {
"#ad-footer-small-wrapper",
].join(",");

cache.cursor = qsa(cursorSelector);
cache.focus = qsa(elementsSelector);

cacheReady = true;
Expand All @@ -44,6 +42,7 @@ function initializeCache(): void {
export function set(value: boolean, withCursor = false): void {
requestDebouncedAnimationFrame("focus.set", () => {
initializeCache();
cache.cursor = qsa("body, button, a");

if (value && !getFocus()) {
setFocus(true);
Expand All @@ -52,7 +51,7 @@ export function set(value: boolean, withCursor = false): void {
if (cache.focus) {
cache.focus.addClass("focus");
}
if (!withCursor && cache.cursor) {
if (!withCursor && cache.cursor !== undefined) {
cache.cursor.setStyle({ cursor: "none" });
}

Expand All @@ -67,7 +66,7 @@ export function set(value: boolean, withCursor = false): void {
if (cache.focus) {
cache.focus.removeClass("focus");
}
if (cache.cursor) {
if (cache.cursor !== undefined) {
cache.cursor.setStyle({ cursor: "" });
}

Expand Down