Replace XtOffsetOf() with offsetof() for PHP 8.6#2008
Open
andypost wants to merge 1 commit intomongodb:v2.xfrom
Open
Replace XtOffsetOf() with offsetof() for PHP 8.6#2008andypost wants to merge 1 commit intomongodb:v2.xfrom
andypost wants to merge 1 commit intomongodb:v2.xfrom
Conversation
Author
|
Looks the failure is preexisting |
GromNaN
reviewed
Apr 30, 2026
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
Thank you very much for taking care of this update. We really appreciate it.
andypost
changed the title
PHP 8.6 removed XtOffsetOf from php_stdint.h, so use the standard offsetof macro for object fetch helpers.
GromNaN
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6 removed
XtOffsetOf(), which was an alias for the standard Coffsetof()macro. Replace all usages withoffsetof()directly.replace 's/XtOffsetOf/offsetof/g'
ref php/php-src@7114314