MONGOCRYPT-432 always initialize out and key_id_out#1154
Merged
kevinAlbs merged 2 commits intomongodb:masterfrom May 1, 2026
Merged
MONGOCRYPT-432 always initialize out and key_id_out#1154kevinAlbs merged 2 commits intomongodb:masterfrom
out and key_id_out#1154kevinAlbs merged 2 commits intomongodb:masterfrom
Conversation
Resolves Coverity issue with CID: 202881. Matches documentation of `_mongocrypt_key_broker_decrypted_key_by_name`
connorsmacd
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize out-params in
_mongocrypt_key_broker_decrypted_key_by_idand_mongocrypt_key_broker_decrypted_key_by_nameon error.Details
Addresses Coverity issue with CID 202881.
_mongocrypt_key_broker_decrypted_key_by_(id|name)documents outputs are: "always initialized, even on error". This does not match the implementation. Changes MONGOCRYPT-432 expect the initialization.IMO this is a low-severity issue, but worth fixing to match internal documentation. Since the only case an early return would occur is if the functions are called on an incorrect state. I expect that would only be triggered by a libmongocrypt bug (not user code).