[LON-359] Drop qs#230
Open
mt-btanner wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the Vault PRs we don't need
qsanymore; there's a widely supported native way to do it.This adds some helpers using
URLSearchParamsto get the types right/get aroundObject.fromEntriesnot being available in the JS versions we target, and replaces all usage ofqswith them.I did have to change one test to get it to pass, because
qsencoded characters which shouldn't be encoded according to the spec and didn't encode spaces as+. I don't think this is likely to be a breaking change since it's just conforming to the spec, but let me know if you think otherwise.