Skip to content

fix: popover action bar behind modal #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdgao merged 2 commits into from
Apr 27, 2026
Merged

fix: popover action bar behind modal #5937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabb0e2
fix: popover action bar behind modal
tdgao Apr 27, 2026
7d6c4c4
fix: only below modal for backups
tdgao Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ui/src/components/base/FloatingActionBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@ import { useModalStack } from '../../composables/modal-stack'
const props = defineProps<{
shown: boolean
ariaLabel?: string
belowModal?: boolean
}>()

const toolbarEl = ref<HTMLElement | null>(null)
const compact = ref(false)

const { stackCount } = useModalStack()
const zIndex = computed(() => 100 + stackCount.value * 10 + 8)
const zIndex = computed(() => 100 + stackCount.value * 10 + 8 + (!props.belowModal ? 1 : 0))

function checkCompact() {
const el = toolbarEl.value
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/layouts/wrapped/hosting/manage/backups.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@
</div>

<FloatingActionBar
below-modal
:shown="selectedIds.size > 0 || isBulkOperating"
:aria-label="
formatMessage(messages.bulkBarAriaLabel, {
Expand Down
Loading