#461: Files in the root on top instead of mixed with directories#519
Open
BowlOfSoup wants to merge 1 commit into
Open
#461: Files in the root on top instead of mixed with directories#519BowlOfSoup wants to merge 1 commit into
BowlOfSoup wants to merge 1 commit into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using hunk I couldn't make a distinction between files in the root and files in directories. This was also stated in issue #461. I didn't solve it as proposed, because that would still mix directory files and root files (except the root files wouldn't be indented). The root files are now 'hoisted' to the top, while still adhering to the original VCS sorting.
I would be fine by exactly implementing the proposal in #461, but I settled on the current fix.
Thanks in advance!