-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Dev #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mi804
wants to merge
13
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #1403
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f88b99c
diffusion skills framework
Artiprocher 9f8c352
Diffusion Templates framework
Artiprocher 59b4bbb
update template framework
Artiprocher f58ba5a
update docs
Artiprocher 13f2618
add a new model
Artiprocher b51fac3
template age
mi804 5e10e11
refine code
Artiprocher 89cb3f5
minor fix age
mi804 c1e25e6
update docs
Artiprocher 8bd6271
Merge branch 'dev' of https://github.com/modelscope/DiffSynth-Studio …
Artiprocher eb208fc
update docs
Artiprocher 13eb329
update docs
Artiprocher d90e036
update docs
Artiprocher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| /models | ||
| /scripts | ||
| /diffusers | ||
| /.vscode | ||
| *.pkl | ||
| *.safetensors | ||
| *.pth | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for
positive_only_loraandnegative_only_lorahas changed in a way that likely introduces regressions. Previously,clear_lorawas called before loading the pass-specific LoRA, ensuring it was the only active LoRA. Now,clear_lorais called after the forward pass. This has two major side effects:Consider restoring the previous behavior or implementing a mechanism to save and restore the LoRA state.