fix(client): preserve user-supplied Accept header instead of overwriting unconditionally#1804
Open
lanxevo3 wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
fix(client): preserve user-supplied Accept header instead of overwriting unconditionally#1804lanxevo3 wants to merge 3 commits intomodelcontextprotocol:mainfrom
lanxevo3 wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
OAuth 2.1 §3.2 requires token endpoint requests to use application/x-www-form-urlencoded regardless of grant type. Add an explicit header.set() call immediately before the fetch in executeTokenRequest() to prevent any addClientAuthentication implementation from accidentally overriding the Content-Type. Fixes modelcontextprotocol/inspector#1160
…ing unconditionally Custom Accept headers set in MCP server configuration (e.g. 'application/vnd.example.v1+json') were unconditionally overwritten with 'application/json, text/event-stream', breaking APIs that require specific Accept values. Now only sets the default Accept header when no Accept header has already been supplied by the caller. The SSE GET channel Accept header is unaffected since it must always be 'text/event-stream'. Fixes modelcontextprotocol#1646.
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom Accept headers set in MCP server configuration were unconditionally overwritten with 'application/json, text/event-stream', breaking APIs that require specific Accept values.
Before: \headers.set('accept', 'application/json, text/event-stream')\ (always overwrites)
After: Only sets the default Accept header when no Accept header has already been supplied by the caller:
\\ s
if (!headers.has('accept')) {
headers.set('accept', 'application/json, text/event-stream');
}
\\
The SSE GET channel Accept header is unaffected — it must always be 'text/event-stream'.
Fixes #1646.