fix(server): forward list-changed notification options#1777
Draft
theamodhshetty wants to merge 1 commit intomodelcontextprotocol:mainfrom
Draft
fix(server): forward list-changed notification options#1777theamodhshetty wants to merge 1 commit intomodelcontextprotocol:mainfrom
theamodhshetty wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 8256623 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationOptionsthrough thesend*ListChanged()helpers onServerandMcpServersendToolListChanged({ relatedRequestId })is delivered inline on the active POST SSE response@modelcontextprotocol/serverWhy
sendToolListChanged(),sendResourceListChanged(), andsendPromptListChanged()already route throughProtocol.notification(), but their public helpers droppedNotificationOptionsbefore they reached the transport. On streamable HTTP servers without a standalone GET SSE channel, that meant list-changed notifications were silently dropped instead of being attached to the active POST SSE response viarelatedRequestId.Validation
pnpm --filter @modelcontextprotocol/server test -- streamableHttp.test.tspnpm --filter @modelcontextprotocol/server typecheckpnpm --filter @modelcontextprotocol/server lint