feat(conformance): add SEP-2243 header validation tool#997
Open
jstar0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose a conformance tool that exercises server-side SEP-2243 custom parameter header validation.
The Streamable HTTP transport already validates
Mcp-Param-*headers using the called tool's input schema. The conformance server did not advertise any tool with anx-mcp-headerannotation, so thehttp-custom-header-server-validationscenario could not exercise that implementation.Changes
test_custom_headertool with a required string parameter promoted toMcp-Param-Value.get_toolso the transport can cache its schema before handler dispatch.tools/listand echo the validated value fromtools/call.The patch reuses the existing transport validation and does not add another header parser or Base64 decoder.
Verification
The pinned
@modelcontextprotocol/conformance@0.2.0-alpha.9http-custom-header-server-validationscenario also passes all 9 emitted checks, including valid and invalid Base64 values, literal prefix/suffix boundaries, missing custom headers, and JSON-RPC error code-32020. The repository integration test separately covers a syntactically valid Base64 value that decodes to a different body value.Closes #979