feat(auth): add StoredCredentials::new() constructor#778
Open
wpfleger96 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
feat(auth): add StoredCredentials::new() constructor#778wpfleger96 wants to merge 1 commit intomodelcontextprotocol:mainfrom
wpfleger96 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
github-actions
bot
added
T-dependencies
StoredCredentials is #[non_exhaustive] but has no constructor, making it impossible for external crates implementing CredentialStore to construct instances without a serde roundtrip workaround. Add a new() constructor matching the pattern used for other #[non_exhaustive] types in this crate. Fixes modelcontextprotocol#777
wpfleger96
force-pushed
the
wpfleger/stored-credentials-constructor
branch
from
7220060 to
50d1f99
Compare
github-actions
bot
removed
T-dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new()constructor toStoredCredentialsStoredCredentialswas marked#[non_exhaustive]in #715 / #768, but unlike other types in that sweep (e.g.OAuthClientConfig), it didn't get a constructor. External crates implementingCredentialStorethat need to constructStoredCredentialsin theirsave()path currently have to resort to a serde JSON roundtrip, which turns compile-time field mismatches into silent runtime failures.Fixes #777
Test plan
just checkpassesjust testpasses — all existing tests unaffected (they constructStoredCredentialswith struct literals inside the crate, which still works)