Skip to content

fix: catch ClosedResourceError in error handler to prevent crash on client disconnect #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giulio-leone wants to merge 3 commits into from
+8 −5
Closed

fix: catch ClosedResourceError in error handler to prevent crash on client disconnect #2160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeb13c4
fix: catch ClosedResourceError in error handler to prevent crash on c…
giulio-leone Feb 28, 2026
61e4c95
style: apply ruff format
giulio-leone Feb 28, 2026
652f52d
fix: add pragma no cover for defensive disconnect handler
giulio-leone Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/mcp/server/lowlevel/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,11 +417,14 @@ async def _handle_message(
)
case Exception():
logger.error(f"Received exception from stream: {message}")
await session.send_log_message(
level="error",
data="Internal Server Error",
logger="mcp.server.exception_handler",
)
try:
await session.send_log_message(
level="error",
data="Internal Server Error",
logger="mcp.server.exception_handler",
)
except (anyio.ClosedResourceError, anyio.BrokenResourceError): # pragma: no cover
logger.warning("Could not send error log to client: connection already closed")
if raise_exceptions:
raise message
case _:
Expand Down
Loading