Skip to content

ci: sign weekly lockfile commits as github-actions[bot]#2148

Merged
maxisbey merged 2 commits intomainfrom
fix/weekly-update-bot-author
Feb 26, 2026
Merged

ci: sign weekly lockfile commits as github-actions[bot]#2148
maxisbey merged 2 commits intomainfrom
fix/weekly-update-bot-author

Conversation

@maxisbey
Copy link
Contributor

@maxisbey maxisbey commented Feb 26, 2026

The peter-evans/create-pull-request action defaults its author input to ${{ github.actor }}. For scheduled workflow runs, GitHub sets github.actor to a human user (the "schedule owner"), not github-actions[bot]. This causes the weekly lockfile update commits to be incorrectly attributed to a maintainer.

All 6 scheduled runs of this workflow so far have actor: Kludex, likely because @Kludex merged the dependabot PR (#1878) that touched the workflow file shortly after it was created — since bots can't own schedules, GitHub attributed the schedule to the human merger.

Fix

sign-commits: true causes the action to create commits via the GitHub REST API rather than local git. When creating commits this way, no author/committer fields are passed — GitHub automatically uses the token identity (github-actions[bot] for the default GITHUB_TOKEN). Per the action docs, the author/committer inputs are ignored entirely when sign-commits is enabled.

This avoids hardcoding the bot email, and commits get a "Verified" badge as a bonus. Force-push to the fixed weekly branch is explicitly supported via updateRef with force: true. This is the approach used by Gradle, DataDog, Microsoft, and Composer in their scheduled dependency-update workflows.

The only limitations (40MiB per-file, Git LFS incompatibility, SSH deploy keys) don't apply here — uv.lock is ~300KB plain text committed via GITHUB_TOKEN.

Addresses question on #2043.

AI Disclaimer

The peter-evans/create-pull-request action defaults author to
${{ github.actor }}. For scheduled workflows, GitHub assigns this to
a human user (the schedule owner), causing weekly dependency update
commits to be incorrectly attributed to a maintainer rather than the
bot.

Github-Issue: #2043
Kludex
Kludex previously approved these changes Feb 26, 2026
sign-commits: true causes the action to create commits via the GitHub
REST API, automatically using the token identity (github-actions[bot])
for both author and committer. This avoids hardcoding the bot email
and gives commits a Verified badge as a bonus.

The author/committer inputs are ignored when sign-commits is enabled.
@maxisbey maxisbey dismissed stale reviews from Kludex and felixweinberger via 0a11666 February 26, 2026 15:22
Copy link
Contributor

@felixweinberger felixweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better, thanks for checking.

@maxisbey maxisbey changed the title ci: use github-actions[bot] as author for weekly lockfile commits ci: sign weekly lockfile commits as github-actions[bot] Feb 26, 2026
@maxisbey maxisbey merged commit 62575ed into main Feb 26, 2026
32 checks passed
@maxisbey maxisbey deleted the fix/weekly-update-bot-author branch February 26, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants