fix: explicit stderr piping for Jupyter support (#156)#2030
Open
Ashutosh0x wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: explicit stderr piping for Jupyter support (#156)#2030Ashutosh0x wants to merge 2 commits intomodelcontextprotocol:mainfrom
Ashutosh0x wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
…elcontextprotocol#156) In Jupyter environments, stderr from subprocesses isn't directly visible. To fix this, we pipe stderr via subprocess.PIPE and use a background reader task that detects Jupyter (via is_jupyter()) and prints the output with ANSI red coloring. For standard environments, the output is routed to sys.stderr as before. Also updated create_windows_process to accept int for errlog, allowing subprocess.PIPE. Closes modelcontextprotocol#156
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Jupyter environments, stderr from subprocesses isn't directly visible. To fix this, we pipe stderr via subprocess.PIPE and use a background reader task that detects Jupyter (via is_jupyter()) and prints the output with ANSI red coloring. For standard environments, the output is routed to errlog as before.
Also updated create_windows_process to accept int for errlog, allowing subprocess.PIPE.
Closes #156