auth: restrict default CORS origins to loopback #2018
Closed
+94
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth routes currently wrap several OAuth endpoints with Starlette CORSMiddleware using wildcard origins (metadata, token, client registration, revocation; and
cors_middleware()is also used by the simple-auth example for introspection).This PR makes the default safer for network-exposed auth servers while keeping browser-based local tooling working:
cors_middleware()now usesallow_origin_regexwith a loopback-only default (localhost/127.0.0.1/[::1], any port), instead of wildcard origins.cors_origin_regexplumbing:create_auth_routes(..., cors_origin_regex=...)AuthSettings.cors_origin_regex(optional)MCPServerand lowlevelServer.Rationale: avoids the common wildcard-CORS footgun for auth endpoints; non-browser clients are unaffected (no Origin header). If you do want a remote browser client, set
cors_origin_regexexplicitly (e.g.^https://your-ui\.example\.com$).