[Server] Shift away session decode from constructor #238
+65
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
changed the title
chr-hertel
force-pushed
the
refactor-session-construct
branch
from
6fb3204 to
0751310
Compare
Nyholm
previously approved these changes
Feb 8, 2026
Contributor
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
I like this PR.
I added a small small test
| public function __construct( | ||
| protected SessionStoreInterface $store, | ||
| protected Uuid $id = new UuidV4(), | ||
| protected array $data = [], |
Contributor
There was a problem hiding this comment.
This parameter was used only if we could not read from the store...
Seams weird. It is a BC break to remove it (I've updated the label)
Nyholm
approved these changes
Feb 8, 2026
Contributor
|
Thank you |
Member
Author
|
Thanks for taking care @Nyholm 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal was to shift that
json_decodeaway from construct, but maybe a bit opinionated, and arguable when it comes to robustness due to the referenced array handling atm, but not a big fan of doing work like that in the constructor.