feat: enhanced structural validation for validate command#209
Open
bryan-anthropic wants to merge 1 commit intomainfrom
Open
feat: enhanced structural validation for validate command#209bryan-anthropic wants to merge 1 commit intomainfrom
bryan-anthropic wants to merge 1 commit intomainfrom
Conversation
Add three pre-pack validators to catch common runtime failures early:
- validateEntryPoint: checks file exists, extension matches server type,
binary has executable bit (Unix)
- validateCommandVariables: scans mcp_config for unrecognized ${...}
variables against the runtime allowlist
- validateSensitiveFiles: warns about credentials.json, *.pem, *.key,
.ssh/, etc. that would be bundled
validateManifest() now accepts optional { projectDir } to separate the
manifest directory from the source file directory.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpb validatethat catch common runtime failures early:mcp_configfor unrecognized${...}patterns (e.g.${BUNDLE_ROOT}which silently fails at runtime)credentials.json,*.pem,*.key,.ssh/etc. that would be bundledvalidateManifest()accepts optional{ projectDir }to support external manifest pathsCloses #57
Test plan
yarn build— cleanyarn lint— cleanyarn test— 229 pass (218 existing + 11 new)${BUNDLE_ROOT}→ fix to${__dirname}→ pack → MCP initialize succeedscredentials.jsonin subdir → warning (exits 0)🤖 Generated with Claude Code