fix: clear session-scoped UI state on server disconnect#1391
Closed
sampathreddy22 wants to merge 1 commit into
Closed
fix: clear session-scoped UI state on server disconnect#1391sampathreddy22 wants to merge 1 commit into
sampathreddy22 wants to merge 1 commit into
Conversation
4 tasks
Member
|
Hi @sampathreddy22 The issue is against v2, which we are building on a separate branch. It is a completely different codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When switching between servers, the Tools/Prompts/Resources result panels were still showing output from the previous session. The root cause is that
App.tsxholds several pieces of session-scoped state that were never reset when the connection dropped.Changes:
useEffectkeyed onconnectionStatusthat clears session state on"disconnected"or"error"toolResult,promptContent,resourceContent,resourceContentMaplogLevelto"info"tools,prompts,resources,resourceTemplates) and their selection state — without this, the previous server's tool list was still visible in the Tools panel until the new server's list loadedAll three disconnect paths are covered: explicit disconnect, reconnect/restart toggle, and mid-session transport failure.