mcp: use golang.org/x/time/rate for LoggingHandler rate limiting#927
Open
wucm667 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
mcp: use golang.org/x/time/rate for LoggingHandler rate limiting#927wucm667 wants to merge 1 commit intomodelcontextprotocol:mainfrom
wucm667 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Replace manual time-based rate limiting with golang.org/x/time/rate.Limiter for LoggingHandler. This provides a proper token bucket algorithm with better accuracy and standard library support. The rate limiter allows one log message per second with a burst of 5, matching the original intent while being more robust. Signed-off-by: wucm667 <stevenwucongmin@gmail.com> Closes modelcontextprotocol#924
wucm667
force-pushed
the
fix/logging-rate-limiter
branch
from
9a830b8 to
20bd8ec
Compare
wucm667
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the simple time-interval check in
LoggingHandlerwith a standardrate.Limiterfromgolang.org/x/time/rate, as suggested by the existing TODO comment.This provides a well-tested implementation and removes the need for manual
lastMessageSenttracking. The rate (1/MinInterval) and burst (1) match the previous behavior exactly./cc @jba
Closes #924