Skip to content

fix(pdf-server): detached-buffer on range re-request + stale e2e assertion #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochafik merged 2 commits into from
Mar 23, 2026
+7 −3
Merged

fix(pdf-server): detached-buffer on range re-request + stale e2e assertion #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5bb277
fix(pdf-server): slice bytes before onDataRange to avoid detached buffer
ochafik Mar 23, 2026
efed982
test(e2e): update pdf-annotations assertion for new display_pdf promp…
ochafik Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion examples/pdf-server/src/mcp-app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3875,7 +3875,11 @@ async function loadPdfProgressively(urlToLoad: string): Promise<{
requestDataRange(begin: number, end: number) {
fetchRange(urlToLoad, begin, end)
.then((result) => {
this.onDataRange(begin, result.bytes);
// PDF.js transfers the ArrayBuffer to its worker, detaching it.
// Pass a copy so the rangeCache entry stays valid for re-requests
// (iOS/WKWebView re-requests ranges under memory pressure and
// throws "Buffer is already detached" on the cached original).
this.onDataRange(begin, result.bytes.slice());
})
.catch((err: unknown) => {
log.error(`Error fetching range ${begin}-${end}:`, err);
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/pdf-annotations.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function extractViewUUID(page: Page): Promise<string> {
const resultText = (await resultContent.textContent()) ?? "";

// Extract viewUUID from the JSON result
// The text content includes: "Displaying PDF (viewUUID: <uuid>): ..."
// The text content includes: "PDF opened. viewUUID: <uuid>"
const match = resultText.match(/viewUUID["\s:]+([a-f0-9-]{36})/);
if (!match) {
throw new Error(
Expand Down Expand Up @@ -107,7 +107,7 @@ test.describe("PDF Server - Annotations", () => {
// (interact action list lives in the tool description, not the runtime result).
expect(resultText).toContain("viewUUID");
expect(resultText).toContain("interactEnabled");
expect(resultText).toContain("Displaying PDF");
expect(resultText).toContain("PDF opened");
});

test("interact tool is available in tool dropdown", async ({ page }) => {
Expand Down
Loading