Register ping handler on McpClient to support server-initiated pings#1391
Open
Register ping handler on McpClient to support server-initiated pings#1391
Conversation
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing ping request handler in McpClientImpl
Register ping handler on McpClient to support server-initiated pings
Feb 25, 2026
stephentoub
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the MCP spec,
pingcan be initiated by either party.McpClientImplnever registered a handler for thepingmethod, causing server→client pings to fail with-32601 MethodNotFound.Changes
McpClientImpl.RegisterHandlers: Unconditionally registers apingrequest handler that returns an emptyPingResult, matching the existingConfigurePing()behavior on the server side.McpClientTests: AddsServerCanPingClienttest that sends apingfrom the server to the connected client and asserts a successful response.Original prompt
This pull request was created from Copilot chat.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.