Fixed issue 627#960
Merged
michelebastione merged 1 commit intoMay 15, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GetCellValue method in ExcelOpenXmlSheetWriter to support custom Excel styles for string values by utilizing the ExcelFormatId from columnInfo. It also includes a new test case, TestIssue627, which validates that string values are correctly handled when a specific format is applied. The reviewer recommended enhancing the test to explicitly verify the applied style or number format on the cell to ensure the style linking logic is functioning as expected.
Corrected oversight that prevented text cells to be linked to a style and added regression test
michelebastione
force-pushed
the
fix-issue-627
branch
from
5c33ebd to
ddd70d7
Compare
michelebastione
merged commit 822e1e7
into
mini-software:v1.x-maintenance
3 checks passed
michelebastione
added a commit
that referenced
this pull request
May 15, 2026
Updated version number from 1.44.0 to 1.44.1 in the project file following hotfix from #960 Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected oversight that prevented text cells to be linked to a style and added a regression test.
Fixes #627