Backported PR 955 enhancing formatting capabilities#957
Merged
michelebastione merged 2 commits intoMay 13, 2026
Merged
Conversation
Read mini-software#955 for reference
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors OpenXml writing logic to centralize style management via SheetStyleBuildContext and SheetStyleFormatsCache, while adding support for TimeSpan, DateTimeOffset, and TimeOnly types. Feedback identifies a naming and logic error in GetSheetStyleBuilderAsync, an unused cryptography import, and a recurring typo in preprocessor directives targeting '.NET 10'. Reviewers also recommend restoring a removed cancellation check and adopting more idiomatic practices for string comparisons and TimeSpan calculations.
michelebastione
force-pushed
the
formatting-fixes
branch
from
7bc841f to
e7f7136
Compare
michelebastione
merged commit 661df82
into
mini-software:v1.x-maintenance
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the
ExcelFormatAttributepreserve the original numerical type of the data when exporting numbers and dates rather than serializing them to string.Read #955 for reference.