Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the ModSecurity Core Rule Set configuration for the agent image to improve maintainability and make rule exclusions more flexible. The most significant change is the introduction of a new exclusion rules file, which allows for easier customization of security rule behavior for the cluster. Additionally, the previous custom content-type allowance has been removed in favor of managing such exceptions in the new exclusion file.
ModSecurity configuration improvements:
RESPONSE-999-EXCLUSION-RULES-AFTER-CRS.confto the agent image, providing a dedicated place for local rule exclusions and customizations, including disabling specific rules (such as 920420 for Content-Type enforcement) and offering examples for further customization. [1] [2]SecActionincrs-setup.confthat previously allowed additional content types (e.g.,application/x-protobuf), shifting responsibility for such changes to the new exclusion rules file for better maintainability and clarity.