Configuration processor auditing improvements#6193
Open
JohnMcPMS wants to merge 9 commits intomicrosoft:masterfrom
Open
Configuration processor auditing improvements#6193JohnMcPMS wants to merge 9 commits intomicrosoft:masterfrom
JohnMcPMS wants to merge 9 commits intomicrosoft:masterfrom
Conversation
florelis
previously approved these changes
May 7, 2026
Member
florelis
left a comment
There was a problem hiding this comment.
I'm not familiar with the configuration code, so my review of that part was superficial and it may be wise to get somebody else to look at it.
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "doc", "doc", "{3FF6C881-2548-486E-8D70-7555A90030F5}" | ||
| ProjectSection(SolutionItems) = preProject | ||
| ..\doc\windows\package-manager\winget\returnCodes.md = ..\doc\windows\package-manager\winget\returnCodes.md | ||
| ..\doc\Settings.md = ..\doc\Settings.md |
Member
There was a problem hiding this comment.
Should we move all the .mds here?
Comment on lines
+195
to
+196
| result.IsAlias = true; | ||
| result.HashString = Utility::SHA256::ConvertToString( |
Member
There was a problem hiding this comment.
Could we extract the signer/publisher from the package that owns the alias?
Member
Author
There was a problem hiding this comment.
We don't know that with OS APIs. We could infer things about the path and likely find the family name, then the full name, then extract the signing information. But all of that is a guess, and a bad actor could easily replace the alias contents while we claimed signature information from the other package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
When a processor path is provided, inform the user about that fact in the output. Ensure that the server agrees on the hash of the processor that is provided in its CLI arguments.
When the target processor is an app execution alias, the hash is of the contents of the reparse point data. Otherwise, it is a hash of the contents of the file itself.
Validation
Tests are added for the scenario and individual operations.
Microsoft Reviewers: Open in CodeFlow