Reset default sources without dropping them#6187
Open
Trenly wants to merge 4 commits intomicrosoft:masterfrom
Open
Reset default sources without dropping them#6187Trenly wants to merge 4 commits intomicrosoft:masterfrom
Trenly wants to merge 4 commits intomicrosoft:masterfrom
Conversation
microsoft-github-policy-service
Bot
added
the
Issue-Bug
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Apr 29, 2026
JohnMcPMS
reviewed
May 7, 2026
| { | ||
| SourceList sourceList; | ||
|
|
||
| auto source = sourceList.GetCurrentSource(name); |
Member
There was a problem hiding this comment.
While we are at it, should we also get tombstones here so you can reset winget if you have removed it?
Comment on lines
+1067
to
+1071
|
|
||
| if (!metadataSet) | ||
| { | ||
| OverwriteSourceList(); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (!metadataSet) | |
| { | |
| OverwriteSourceList(); | |
| } |
We don't need to reload the source list after failing to update the metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow