Add 'hint' and 'info' search keywords to editor.hover.enabled#313491
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
Add 'hint' and 'info' search keywords to editor.hover.enabled#313491yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional settings-search synonyms for the editor hover “gateway” setting so users can find hover-related settings when searching for “hint”, “info”, or “tooltip”, addressing #56902.
Changes:
- Adds a
keywordsarray toeditor.hover.enabledwithhint,info, andtooltip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56902
@roblourens confirmed in 2018 ("Yeah makes sense") that adding "hint"/"info" as synonyms for "hover" in settings search would be reasonable. Implements that via the
keywordsarray on the gateway hover setting.Adds
keywords: ['hint', 'info', 'tooltip']toeditor.hover.enabledonly — the gateway setting that surfaces all editor.hover.* in the search panel. Searching "hint", "info", or "tooltip" now returns the hover settings, which the existing keyword-search code path inpreferencesSearch.tsuses by joiningsetting.keywordsinto the searchable lines alongside the description.Scope kept narrow to the gateway setting per the maintainer's "Yeah makes sense" — doesn't blanket-apply to every hover sub-setting.