Add 'pane' search keyword to editor group settings#313490
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
Add 'pane' search keyword to editor group settings#313490yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds “pane” as a settings-search synonym for a few editor-group related settings so that searching for “pane” surfaces the expected results in the Settings UI (leveraging the existing keywords search path).
Changes:
- Add
keywords: ['pane']toworkbench.editor.splitSizing. - Add
keywords: ['pane']toworkbench.editor.splitOnDragAndDrop. - Add
keywords: ['pane']toworkbench.editor.closeEmptyGroups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65795
@roblourens confirmed in 2018 that adding "pane" as a synonym for "editor group" in settings search would be reasonable. Adds the
keywordsarray (the documented search-synonym field onIConfigurationPropertySchema) to the three editor-group settings most directly affected:workbench.editor.splitSizingworkbench.editor.splitOnDragAndDropworkbench.editor.closeEmptyGroupsThese are the settings where searching "pane" most obviously fails to surface relevant results today (each is described in terms of "editor group" / "splitting" but never uses the word "pane"). Searches that used "pane" terminology now return them via the existing keyword-search code path in
preferencesSearch.ts.