feat: enhance telemetry with error classification and duration tracking for environment manager registration#1292
Open
eleanorjboyd wants to merge 6 commits intomicrosoft:mainfrom
Open
feat: enhance telemetry with error classification and duration tracking for environment manager registration#1292eleanorjboyd wants to merge 6 commits intomicrosoft:mainfrom
eleanorjboyd wants to merge 6 commits intomicrosoft:mainfrom
Conversation
…ng for environment manager registration
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances telemetry tracking for environment manager operations by introducing structured error classification and duration metrics. The changes help identify specific error types (spawn failures, timeouts, permission issues, etc.) and measure performance for environment discovery and manager registration.
Changes:
- Added a new error classification module (
errorClassifier.ts) that categorizes errors into telemetry-safe types - Updated environment discovery telemetry to use classified error types instead of raw error names
- Added duration tracking to environment manager registration via StopWatch
- Added error telemetry for extension manager registration failures in extension.ts
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/common/telemetry/errorClassifier.ts |
New module providing classifyError() function that maps errors to structured types (spawn_timeout, spawn_enoent, permission_denied, canceled, parse_error, unknown) |
src/internal.api.ts |
Updated ENVIRONMENT_DISCOVERY telemetry to use classifyError() for more granular error categorization |
src/features/envManagers.ts |
Added StopWatch to track and report duration for environment manager registration |
src/extension.ts |
Added error telemetry in catch block for manager registration failures |
src/common/telemetry/constants.ts |
Updated GDPR annotations to include duration measurement for ENVIRONMENT_MANAGER_REGISTERED event |
aeschli
previously approved these changes
Feb 27, 2026
aeschli
previously approved these changes
Feb 27, 2026
# Conflicts: # src/extension.ts # src/internal.api.ts
alexdima
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
help identify what could be causing discovery errors and which managers may be taking a while to load