Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: feature
packages:
- "@typespec/http-client-java"
---

Add a warning when emitter does not spread for json-merge-patch payload.
5 changes: 5 additions & 0 deletions packages/http-client-java/emitter/src/code-model-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2077,6 +2077,11 @@ export class CodeModelBuilder {

if (jsonMergePatch) {
// skip model flatten, if "application/merge-patch+json"
reportDiagnostic(this.program, {
code: "spread-json-merge-patch-payload-not-supported",
target: sdkMethod.__raw ?? NoTarget,
});

if (sdkType.isGeneratedName) {
schema.language.default.name = pascalCase(op.language.default.name) + "PatchRequest";
}
Expand Down
7 changes: 7 additions & 0 deletions packages/http-client-java/emitter/src/lib.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,13 @@ export const $lib = createTypeSpecLibrary({
default: paramMessage`Constant header '${"headerName"}' is removed from response headers.`,
},
},
"spread-json-merge-patch-payload-not-supported": {
severity: "warning",
messages: {
default:
"Spread JSON merge-patch payload is not supported. The reason is that a property in JSON merge-patch payload class can: set a value; not set so that value does not change; set to null to remove the value. A parameter on method cannot distinguish the latter 2 cases.",
},
},
},
emitter: {
options: EmitterOptionsSchema,
Expand Down
Loading