Replace ESLint with oxlint#10970
Draft
timotheeguerin wants to merge 3 commits into
Draft
Conversation
microsoft-github-policy-service
Bot
added
compiler:core
@typespec/asset-emitter
@typespec/bundler
@typespec/compiler
@typespec/emitter-framework
@typespec/events
@typespec/html-program-viewer
@typespec/http
@typespec/http-canonicalization
@typespec/http-client
@typespec/http-client-js
@typespec/http-server-csharp
@typespec/http-server-js
@typespec/internal-build-utils
@typespec/json-schema
@typespec/library-linter
@typespec/mutator-framework
@typespec/openapi
@typespec/openapi3
@typespec/playground
@typespec/protobuf
@typespec/rest
@typespec/sse
@typespec/streams
tmlanguage-generator
@typespec/tspd
@typespec/versioning
@typespec/xml
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the entire monorepo linting from ESLint to oxlint (oxc-project).
Motivation
@typespec/eslint-pluginpackage and its build step in CI. One less package to maintain.eslint,typescript-eslint,@eslint/js,@vitest/eslint-plugin,eslint-plugin-react-hooks, andeslint-plugin-unicornfrom the dependency tree.Changes
Removed
eslint.config.js— the root ESLint flat configpackages/eslint-plugin-typespec/— the custom ESLint plugin (including thecall-decoratorrule)eslint,typescript-eslint,@eslint/js,@vitest/eslint-plugin,eslint-plugin-unicorn,eslint-plugin-react-hooks)Added
oxlint.config.ts— new root oxlint configuration covering:typescript-eslint/recommended).tsfiles).tsxfiles (excluding alloy-jsx emitter packages)oxlint(^1.69.0) as a root devDependencyTypeSpecCommonOxlintConfigsfor downstream repos (e.g., typespec-azure) to reuseUpdated
package.json:lint→oxlint . --deny-warnings,lint:fix→oxlint . --fixpackage.jsonlint scripts: same pattern.github/workflows/consistency.yml: removed the eslint plugin build step (oxlint needs no pre-build).vscode/extensions.json: recommend oxc extension instead of ESLint extensionRule Parity
The oxlint config replicates the effective ESLint rule set with these intentional differences:
typespec/call-decoratorrule has no oxlint equivalent and is dropped (low-signal rule)no-control-regexandno-unsafe-optional-chainingare explicitly disabled (intentional patterns in the codebase)