feat(http-client-csharp): add ParameterProvider.Invoke overload accepting extensionType#10538
Open
JoshLove-msft wants to merge 2 commits intomicrosoft:mainfrom
Open
feat(http-client-csharp): add ParameterProvider.Invoke overload accepting extensionType#10538JoshLove-msft wants to merge 2 commits intomicrosoft:mainfrom
JoshLove-msft wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…ting extensionType Adds an overload of Invoke(this ParameterProvider, string, IReadOnlyList<ValueExpression>, IReadOnlyList<CSharpType>, CSharpType?) so callers in downstream emitters (e.g. Azure.Generator) can construct an InvokeMethodExpression with ExtensionType set in a single expression instead of constructing it and then calling Update(extensionType: ...). The existing 4-arg overload is preserved for source compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoshLove-msft
requested review from
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
commit: |
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an overload of
Invoke(this ParameterProvider, string, IReadOnlyList<ValueExpression>, IReadOnlyList<CSharpType>, CSharpType?)toMicrosoft.TypeSpec.Generator.Snippets.Snippetso downstream emitters can construct anInvokeMethodExpressionwithExtensionTypeset in a single expression instead of constructing it and then callingUpdate(extensionType: …).Motivated by Azure/azure-sdk-for-net#58615 (review), where
ClientHostExtensionsDefinitioncurrently has to do:After this change it can be:
The existing 4-arg overload is preserved as-is for source compatibility.