Refactor repeated object property access to destructuring across repo#5747
Refactor repeated object property access to destructuring across repo#5747
Conversation
…gin constructors Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/d16ff30b-dbf7-4053-9480-28378c1626b8 Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/69ee967b-8010-4fce-9002-5746b3573f14 Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
|
@copilot - this change needs changefiles. Run None of this should affect package consumers, right? |
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/cbc09497-8eb2-4b35-a252-1cb371b05810 Co-authored-by: iclanton <5010588+iclanton@users.noreply.github.com>
Correct, none of this affects package consumers — purely mechanical destructuring with no behavioral changes. Added change files with |
iclanton
requested review from
apostolisms,
bmiddha,
dmichon-msft,
jxanthony and
octogonz
as code owners
dmichon-msft
left a comment
dmichon-msft
left a comment
There was a problem hiding this comment.
@copilot These changes are incomplete. Defaulting should also be handles as part of migrating to destructuring.
rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-http-build-cache-plugin/src/HttpBuildCacheProvider.ts
Outdated
Show resolved
Hide resolved
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/2fa38687-8cb7-4932-b927-0db70e54c476 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/2fa38687-8cb7-4932-b927-0db70e54c476 Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
dmichon-msft
left a comment
dmichon-msft
left a comment
There was a problem hiding this comment.
Just one minor adjustment left, otherwise looks good
watch,phase.phaseName)weight,metadata)watchDebounceMs)rushAlertsState)textRewriters)defaultParameters)readFile,globsToIgnore,terminal)loginFlowFailover)uploadMethod,headers,cacheKeyPrefix,minHttpRetryDelayMs)globalRouting)