Do not create m_childrenContainer when using a custom visual to mount children into#15877
Merged
acoates-ms merged 3 commits intomicrosoft:mainfrom Mar 31, 2026
Merged
Conversation
vmoroz
approved these changes
Mar 30, 2026
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Mar 31, 2026
… children into (microsoft#15877) * Do not create m_childrenContainer when using a custom visual to mount children into * Change files * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The implementation of overflow:"hidden" creates a new container visual, which would bypass a custom visual provided by SetVisualToMountChildrenIntoHandler. It would also crash trying to remove existing visuals from Visual(), when they are actually in VisualToMountChildrenInto().
Resolves #15875
Microsoft Reviewers: Open in CodeFlow