Skip to content

Revert "fix(trace-viewer): add keyboard navigation to NetworkFilters component"#41280

Merged
yury-s merged 1 commit into
mainfrom
revert-41177-fix/network-filters-keyboard-nav
Jun 12, 2026
Merged

Revert "fix(trace-viewer): add keyboard navigation to NetworkFilters component"#41280
yury-s merged 1 commit into
mainfrom
revert-41177-fix/network-filters-keyboard-nav

Conversation

@yury-s

@yury-s yury-s commented Jun 12, 2026

Copy link
Copy Markdown
Member

@triemerge

Copy link
Copy Markdown
Contributor

I think the test failure is because #41200 added WS to the resource type filters, so Image is "no longer" the last tab. The End key assertion should expect WS instead of Image. Happy to re-submit with the fix once this is sorted.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

7328 passed, 1122 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/video.spec.ts:645 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:717 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92 › should remove cookies by domain `@webkit-ubuntu-22.04-node20`

39550 passed, 743 skipped


Merge workflow run.

@yury-s yury-s merged commit e25d571 into main Jun 12, 2026
46 checks passed
@yury-s yury-s deleted the revert-41177-fix/network-filters-keyboard-nav branch June 12, 2026 21:08
@yury-s

yury-s commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

I think the test failure is because #41200 added WS to the resource type filters, so Image is "no longer" the last tab. The End key assertion should expect WS instead of Image. Happy to re-submit with the fix once this is sorted.

Feel free to resubmit fixed version, we are preparing to cur release branch and this was a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants