fix: preserve currency formatting in XLSX conversion (#53)#2149
Open
BB0813 wants to merge 1 commit into
Open
Conversation
When Excel cells use currency number formats (e.g. $#,##0.00 or €#,##0.00), pandas only reads the raw numeric value and discards the currency symbol. This caused output like '5' instead of '$5'. After reading the DataFrame with pandas, we now use openpyxl to inspect each cell's number_format. Numeric cells with currency formats get their values replaced with formatted strings so the currency symbol is preserved in the Markdown output. Supports: - Standard formats: $#,##0.00, €#,##0.00, £#,##0.00, etc. - Accounting formats: _($* #,##0.00_) - Decimal precision matching the format string (e.g. $5.00, €199) - Negative values: -$50.50 - 14 common currency symbols Fixes microsoft#53
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Excel cells use currency number formats (e.g. $#,##0.00 or €#,##0.00), pandas only reads the raw numeric value and discards the currency symbol. This caused output like '5' instead of '$5'.
After reading the DataFrame with pandas, we now use openpyxl to inspect each cell's number_format. Numeric cells with currency formats get their values replaced with formatted strings so the currency symbol is preserved in the Markdown output.
Supports:
Fixes #53