added specs pkg to generate LCOW Sandbox Specs from annotations and options#2616
Open
rawahars wants to merge 1 commit intomicrosoft:mainfrom
Open
added specs pkg to generate LCOW Sandbox Specs from annotations and options#2616rawahars wants to merge 1 commit intomicrosoft:mainfrom
rawahars wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This commit adds a specs package to `containerd-shim-lcow-v1` shim. This package encapsulates the business logic to parse the annotations + devices + runhcs options into the Sandbox Spec which will be used by the shim to create UVMs via HCS. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the
specspackage adding functionality for parsing and generating sandbox specifications for LCOW scenarios. The changes provide detailed logic for handling cpu options, memory options, boot options, confidential computing settings, and device configurations, all driven by annotations and runtime options.This package consolidates the LCOW logic present in old shim from various sources into a single package.
The sandbox specs generated from this package can be used to create an LCOW. No additional parsing would be required in the shim.
Note: This PR can only be merged after #2609
Documentation:
Introduced a comprehensive package-level doc comment in
doc.godescribing the purpose, entry points, and configuration areas handled by thespecspackage.Testing
Added unit tests for the parsing logic testing.