Skip to content

Fix whitespace-only LanceDB db_uri fallback#2391

Open
yuzhiyang1 wants to merge 1 commit into
microsoft:mainfrom
yuzhiyang1:codex/fix-vector-store-db-uri-strip
Open

Fix whitespace-only LanceDB db_uri fallback#2391
yuzhiyang1 wants to merge 1 commit into
microsoft:mainfrom
yuzhiyang1:codex/fix-vector-store-db-uri-strip

Conversation

@yuzhiyang1
Copy link
Copy Markdown

Description

Fixes LanceDB vector store db_uri validation so whitespace-only values fall back to the default db_uri instead of resolving to the current working directory.

Related Issues

Fixes #2381

Proposed Changes

  • Call strip() when checking whether the LanceDB db_uri is blank.
  • Add a unit test covering whitespace-only db_uri values.
  • Add a semversioner patch change entry.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

Additional Notes

Validation run locally:

  • uv run pytest tests/unit/config/test_config.py -q
  • uv run ruff format packages/graphrag/graphrag/config/models/graph_rag_config.py tests/unit/config/test_config.py --check
  • uv run ruff check packages/graphrag/graphrag/config/models/graph_rag_config.py tests/unit/config/test_config.py

@yuzhiyang1 yuzhiyang1 requested a review from a team as a code owner June 1, 2026 10:20
@yuzhiyang1
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: vector store db_uri whitespace check uses .strip without parentheses, always False

1 participant