Fix sqlcmd hanging for ~10 minutes after query timeout on Linux#682
Open
Fix sqlcmd hanging for ~10 minutes after query timeout on Linux#682
Conversation
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix sqlcmd command timeout handling on Linux
Fix sqlcmd hanging for ~10 minutes after query timeout on Linux
Jan 31, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where sqlcmd hangs for approximately 10 minutes after a query timeout on Linux systems. The root cause was a missing rows.Close() call in the runQuery() function, which left database connections open and caused the TCP stack on Linux to wait for cleanup. The fix adds the standard Go pattern of defer rows.Close() immediately after QueryContext() to ensure connections are properly released.
Changes:
- Added
defer rows.Close()call with nil check inrunQuery()function to properly release database connections when the function returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, sqlcmd with
-tflag correctly prints "Timeout expired" but hangs for ~10 minutes before exiting. Works correctly on Windows.Root Cause
runQuery()never closes thesql.Rowsobject returned byQueryContext(). On timeout, the connection remains open. Linux TCP stack waits ~10 minutes for cleanup; Windows cleans up more aggressively.Changes
Added missing
defer rows.Close()immediately afterQueryContext():This releases the connection immediately when the function returns, regardless of error or timeout conditions.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.