fix(web-components): stopImmediatePropagation on internalProxyAnchors#36085
Open
davatron5000 wants to merge 2 commits intomicrosoft:masterfrom
Open
fix(web-components): stopImmediatePropagation on internalProxyAnchors#36085davatron5000 wants to merge 2 commits intomicrosoft:masterfrom
davatron5000 wants to merge 2 commits intomicrosoft:masterfrom
Conversation
chrisdholt
approved these changes
May 1, 2026
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Accordion 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png | 3154 | Changed |
vr-tests-web-components/Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium.png | 10380 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/MenuList 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - Dark Mode.normal.chromium.png | 498 | Changed |
radium-v
reviewed
May 3, 2026
Comment on lines
+200
to
+202
| await element.evaluate(node => { | ||
| (node as HTMLElement).click(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Does await element.click() work here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
AnchorButton and Link were triggering duplicate clicks. Repro: https://stackblitz.com/edit/vitejs-vite-selgj5w1?file=src%2Fstyle.css,index.html,src%2Fmain.ts&terminal=dev
New Behavior
Use
stopImmediatePropagationto prevent click from bubbling up form InternalProxyAnchor.Related Issue(s)