feat(react-headless-components-preview): add headless Toast component family#36059
Draft
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Draft
feat(react-headless-components-preview): add headless Toast component family#36059dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 4 | Changed |
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 2 | Changed |
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 2210 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png | 676 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 668 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 2293 | Changed |
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 413 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 957 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 193 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 133 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 41 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
Co-authored-by: Copilot <copilot@github.com>
dmytrokirpa
force-pushed
the
feat/headless-toast
branch
from
55857f5 to
bd53445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds headless wrappers for the
react-toastcomponent surface to@fluentui/react-headless-components-preview, built on top of the base hooks from #35914.ToastuseToastBase_unstableBackgroundAppearanceProviderwrapper;appearanceprop omittedToastTitleuseToastTitleBase_unstablemediaslot has no automatic intent icon; consumers supply their ownToastBodyuseToastBodyBase_unstablebackgroundAppearancestateToastFooteruseToastFooter_unstableToasterandToastContainerare omitted — their state management is infrastructure-level with no design-only props to strip.How renderToast works
renderToast_unstablewraps output in<BackgroundAppearanceProvider>. The headlessrenderToastpassesbackgroundAppearance: undefined, which is equivalent to no provider — subcomponents receive no appearance context, which is the correct headless behaviour.Test plan
Toastrenders without any appearance styling appliedToastTitlerendersmediaslot empty by default (no icon); consumers can pass their own via themediaslot propToastBodyrenders correctly without background appearance contextToastFooterrenders as a plain divclassName/style🤖 Generated with Claude Code