fix: remove chromium dependencies from rubygem-railties#16922
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 29, 2026
Merged
fix: remove chromium dependencies from rubygem-railties#16922christopherco merged 1 commit intotomls/base/mainfrom
christopherco merged 1 commit intotomls/base/mainfrom
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes browser-based test dependencies from the rubygem-railties package to avoid pulling Chromium (and related GUI browser tooling) into the build/dependency chain.
Changes:
- Drops
selenium-webdriverandchromedriver/chromiumBuildRequires fromrubygem-railties.spec. - Disables a set of
railtiestests that require Selenium/WebDriver (and one failing sprockets test). - Removes the
rubygem-railtiesentry frombase/comps/components.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| specs/r/rubygem-railties/rubygem-railties.spec | Removes Chromium/WebDriver build deps and disables WebDriver-dependent (and one failing) tests. |
| base/comps/components.toml | Removes rubygem-railties from the components list (potentially affecting composition). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5014
to
5015
| [components.rubygem-rails-html-sanitizer] | ||
| [components.rubygem-railties] | ||
| [components.rubygem-rake] |
There was a problem hiding this comment.
The PR description focuses on removing Chromium/WebDriver dependencies from rubygem-railties, but this change removes rubygem-railties entirely from components.toml. If the intent is not to drop the component from the composition, this entry should remain; if it is intentional, the PR description should explicitly call out the component removal and its expected impact.
Comment on lines
62
to
64
| # Chromium availability is limited: | ||
| # https://src.fedoraproject.org/rpms/chromium/blob/0d9761748509bb12051ab149d28c1052cd834f87/f/chromium.spec#_800 | ||
| # and chrome-headless even more: |
There was a problem hiding this comment.
These comments are now misleading because Chromium/chrome-headless BuildRequires were removed in this PR. Please either remove this Chromium-specific comment block or update it to explain the current rationale (e.g., why Selenium/WebDriver tests are disabled instead of pulling browser dependencies).
Comment on lines
151
to
155
| echo 'gem "rack-cache"' >> ../Gemfile | ||
| echo 'gem "rails"' >> ../Gemfile | ||
| echo 'gem "rake"' >> ../Gemfile | ||
| echo 'gem "selenium-webdriver"' >> ../Gemfile | ||
| # selenium-webdriver removed - no chromedriver in Azure Linux | ||
| # Loading Sprockets causes `Expected to find a manifest file in |
There was a problem hiding this comment.
This inserted comment sits inside the sequence of echo ... >> ../Gemfile commands, which can look like it is writing to the Gemfile when it is not. To reduce confusion, consider removing the line entirely (since it’s not a command) and placing the explanation closer to the dependency removals and/or the test disablement block.
Comment on lines
+258
to
+261
| # Azure Linux: disable tests that require selenium-webdriver/chromedriver | ||
| mv test/application/active_job_adapter_test.rb{,.disable} | ||
| mv test/application/system_test_case_test.rb{,.disable} | ||
| mv test/application/test_runner_test.rb{,.disable} |
There was a problem hiding this comment.
This block disables multiple tests under a broad Selenium/WebDriver rationale, but at least one test is disabled for a different reason (sprockets digest in mock chroot). Consider splitting these into separate blocks per failure class and adding a brief per-test reason (or a tracking issue/link) so future updates can re-enable specific tests without re-investigating why they were disabled.
Suggested change
| # Azure Linux: disable tests that require selenium-webdriver/chromedriver | |
| mv test/application/active_job_adapter_test.rb{,.disable} | |
| mv test/application/system_test_case_test.rb{,.disable} | |
| mv test/application/test_runner_test.rb{,.disable} | |
| # Azure Linux: disable tests that require selenium-webdriver/chromedriver | |
| # active_job_adapter_test exercises browser-driven behavior | |
| mv test/application/active_job_adapter_test.rb{,.disable} | |
| # system_test_case_test requires Selenium/WebDriver support | |
| mv test/application/system_test_case_test.rb{,.disable} | |
| # test_runner_test requires Selenium/WebDriver support | |
| mv test/application/test_runner_test.rb{,.disable} |
binujp
force-pushed
the
bphilip/railtienochrome
branch
from
bb57874 to
b392446
Compare
❌ Rendered specs are out of date🚧🚧🚧🚧🚧 Warning Disregard this comment. Spec rendering is still under development and checked-in specs 🚧🚧🚧🚧🚧 FIX: — run this and commit the result: azldev component render -a --clean-staleOr download the fix patch and apply it: gh run download 25086517168 -R microsoft/azurelinux -n rendered-specs-patch
git apply rendered-specs.patch
Content diffs`specs/3/389-ds-base/389-ds-base.spec`--- committed/specs/3/389-ds-base/389-ds-base.spec
+++ rendered/specs/3/389-ds-base/389-ds-base.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 8;
@@ -1123,7 +1123,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 3.1.4-8
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 3.1.4-8
- Latest state for 389-ds-base
* Fri Feb 13 2026 Viktor Ashirov <vashirov@redhat.com> - 3.1.4-7
`specs/7/7zip/7zip.spec`--- committed/specs/7/7zip/7zip.spec
+++ rendered/specs/7/7zip/7zip.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 2;
@@ -138,7 +138,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 25.01-2
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 25.01-2
- Latest state for 7zip
* Wed Nov 26 2025 Michel Lind <salimma@fedoraproject.org> - 25.01-1
`specs/a/AMF/AMF.spec`--- committed/specs/a/AMF/AMF.spec
+++ rendered/specs/a/AMF/AMF.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 2;
@@ -87,7 +87,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 1:1.5.0-2
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 1:1.5.0-2
- Latest state for AMF
* Fri Oct 31 2025 Simone Caronni <negativo17@gmail.com> - 1:1.5.0-1
`specs/a/aardvark-dns/aardvark-dns.spec`--- committed/specs/a/aardvark-dns/aardvark-dns.spec
+++ rendered/specs/a/aardvark-dns/aardvark-dns.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 2;
@@ -130,7 +130,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 2:1.17.0-2
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 2:1.17.0-2
- Latest state for aardvark-dns
* Wed Nov 12 2025 Packit <hello@packit.dev> - 2:1.17.0-1
`specs/a/abseil-cpp/abseil-cpp.spec`--- committed/specs/a/abseil-cpp/abseil-cpp.spec
+++ rendered/specs/a/abseil-cpp/abseil-cpp.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 2;
@@ -267,7 +267,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 20250814.1-2
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 20250814.1-2
- Latest state for abseil-cpp
* Tue Sep 23 2025 Benjamin A. Beasley <code@musicinmybrain.net> - 20250814.1-1
`specs/a/accountsservice/accountsservice.spec`--- committed/specs/a/accountsservice/accountsservice.spec
+++ rendered/specs/a/accountsservice/accountsservice.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 15;
@@ -130,7 +130,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 23.13.9-15
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 23.13.9-15
- Latest state for accountsservice
* Wed Jul 23 2025 Fedora Release Engineering <releng@fedoraproject.org> - 23.13.9-9
`specs/a/adobe-source-code-pro-fonts/adobe-source-code-pro-fonts.spec`--- committed/specs/a/adobe-source-code-pro-fonts/adobe-source-code-pro-fonts.spec
+++ rendered/specs/a/adobe-source-code-pro-fonts/adobe-source-code-pro-fonts.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 8;
@@ -71,7 +71,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 2.042.1.062.1.026-8
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 2.042.1.062.1.026-8
- Latest state for adobe-source-code-pro-fonts
* Wed Jul 23 2025 Fedora Release Engineering <releng@fedoraproject.org> - 2.042.1.062.1.026-7
`specs/a/adwaita-icon-theme-legacy/adwaita-icon-theme-legacy.spec`--- committed/specs/a/adwaita-icon-theme-legacy/adwaita-icon-theme-legacy.spec
+++ rendered/specs/a/adwaita-icon-theme-legacy/adwaita-icon-theme-legacy.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 6;
@@ -87,7 +87,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 46.2-6
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 46.2-6
- Latest state for adwaita-icon-theme-legacy
* Wed Jul 23 2025 Fedora Release Engineering <releng@fedoraproject.org> - 46.2-4
`specs/a/adwaita-icon-theme/adwaita-icon-theme.spec`--- committed/specs/a/adwaita-icon-theme/adwaita-icon-theme.spec
+++ rendered/specs/a/adwaita-icon-theme/adwaita-icon-theme.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 4;
@@ -93,7 +93,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 49.0-4
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 49.0-4
- Latest state for adwaita-icon-theme
* Mon Sep 15 2025 Michael Catanzaro <mcatanzaro@gnome.org> - 49.0-1
`specs/a/afflib/afflib.spec`--- committed/specs/a/afflib/afflib.spec
+++ rendered/specs/a/afflib/afflib.spec
@@ -1,5 +1,5 @@
## START: Set by rpmautospec
-## (rpmautospec version 0.8.4)
+## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 16;
@@ -223,7 +223,7 @@
%changelog
## START: Generated by rpmautospec
-* Wed Apr 22 2026 azldev <azurelinux@microsoft.com> - 3.7.20-16
+* Tue Apr 28 2026 azldev <azurelinux@microsoft.com> - 3.7.20-16
- Latest state for afflib
* Wed Jul 23 2025 Fedora Release Engineering <releng@fedoraproject.org> - 3.7.20-15
… and 3996 more file(s). Run the remediation command above to see all changes. Files to addThese files are produced by
… and 216 more file(s). Files to removeThese files are in your branch but are not produced by render. Remove them.
… and 153 more file(s). |
This is the first step to removing chormium from out component list. Chromium came in because it is a seed from rhel-10 and also because it is a BuildRequires for rubygem-railties via a test dependency. "railties" does a webdriver based test to verify templating. We do not to pull in chromium or any gui browsers unless there is direct or sub-package dependency. With this change merged we can get rid of chromium and possibly a few run and build requirements of chromium itself.
binujp
force-pushed
the
bphilip/railtienochrome
branch
from
b392446 to
cbf6cfd
Compare
12 tasks
christopherco
approved these changes
Apr 29, 2026
christopherco
pushed a commit
that referenced
this pull request
Apr 29, 2026
fixes: AB#19172 Chromium was pulled in via build time dependency on test section of rubygem-railties package. #16922 removes chromium dependency for build. We can remove chromium from component list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step to removing chormium from out component list. Chromium came in because it is a seed from rhel-10 and also because it is a BuildRequires for rubygem-railties via a test dependency. "railties" does a webdriver based test to verify templating. We do not to pull in chromium or any gui browsers unless there is direct or sub-package dependency.
With this change merged we can get rid of chromium and possibly a few run and build requirements of chromium itself.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology