Skip to content

Fix ptest issue for c-ares#16899

Merged
kgodara912 merged 1 commit intomicrosoft:3.0-devfrom
AkarshHCL:topic-ptest_c-ares
Apr 28, 2026
Merged

Fix ptest issue for c-ares#16899
kgodara912 merged 1 commit intomicrosoft:3.0-devfrom
AkarshHCL:topic-ptest_c-ares

Conversation

@AkarshHCL
Copy link
Copy Markdown
Contributor

@AkarshHCL AkarshHCL commented Apr 27, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This PR fixes a ptest failure in c-ares by removing the acountry tool invocation from the %check section.

Upstream has removed the acountry utility starting from c‑ares 1.28.0 because it depended on the external service countries.nerd.dk, which is no longer available. As a result, acountry is no longer built or shipped in current versions.

The %check section previously attempted to run acountry, causing test failures. This PR removes that invocation while keeping the remaining tests intact.

reference-c-ares/c-ares#718

I checked the commits in above link the changes done in upstream commits to remove acountry tool are present in our source code too.

Change Log
  • SPECS/c-ares/c-ares.spec
Does this affect the toolchain?

NO

Test Methodology
  • Screenshot of successful build-
image

@AkarshHCL AkarshHCL requested a review from a team as a code owner April 27, 2026 06:29
@AkarshHCL AkarshHCL marked this pull request as draft April 27, 2026 06:29
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Apr 27, 2026
@AkarshHCL AkarshHCL marked this pull request as ready for review April 27, 2026 07:33
@Kanishk-Bansal Kanishk-Bansal added the ptest package testing (%check section in spec) label Apr 28, 2026
@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

Build

@AkarshHCL
Copy link
Copy Markdown
Contributor Author

Buddy Build is successful.

Copy link
Copy Markdown
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream removed the acountry utility beginning with c-ares 1.28.0, as it relied on the external service countries.nerd.dk, which is no longer accessible. Therefore, acountry is no longer included or built in recent versions.

Previously, the %check section attempted to run acountry, resulting in test failures. This PR removes that step, while preserving the other tests.

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Apr 28, 2026
Copy link
Copy Markdown
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor removal for unsupported binary test. Buddy build is successful. LGTM.

@kgodara912 kgodara912 merged commit 39b7ea8 into microsoft:3.0-dev Apr 28, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec) ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants