Skip to content

fix(dist-git): fix render staging, import-commit seeding, and commit …#139

Merged
dmcilvaney merged 2 commits intomicrosoft:mainfrom
dmcilvaney:damcilva/integrate_new_distgit
Apr 30, 2026
Merged

fix(dist-git): fix render staging, import-commit seeding, and commit …#139
dmcilvaney merged 2 commits intomicrosoft:mainfrom
dmcilvaney:damcilva/integrate_new_distgit

Conversation

@dmcilvaney
Copy link
Copy Markdown
Contributor

…parsing

  • Use project WorkDir for render staging instead of /tmp to avoid filling tmpfs on large batch renders with synthetic git history.
  • Seed import-commit on first update so synthetic history walks have a bounded starting point instead of traversing entire repo histories.
  • Fix TrimRight -> Trim in commit metadata parsing to handle leading newlines that caused hash parse failures.

…parsing

- Use project WorkDir for render staging instead of /tmp to avoid filling
  tmpfs on large batch renders with synthetic git history.
- Seed import-commit on first update so synthetic history walks have a
  bounded starting point instead of traversing entire repo histories.
- Fix TrimRight -> Trim in commit metadata parsing to handle leading
  newlines that caused hash parse failures.
Copilot AI review requested due to automatic review settings April 30, 2026 21:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes performance and correctness issues in dist-git synthetic history generation and commit metadata parsing, and adjusts component render staging to use the project work directory to avoid exhausting /tmp/tmpfs during large batch renders.

Changes:

  • Use project WorkDir for render staging instead of the OS temp dir.
  • Seed import-commit on initial update for upstream components to bound synthetic history walks.
  • Fix git log metadata parsing by trimming leading newlines as well as trailing newlines.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
internal/app/azldev/core/sources/synthistory.go Adjust commit metadata block trimming to handle leading newlines and avoid parse failures.
internal/app/azldev/cmds/component/update.go Seed import-commit for upstream components to bound synthetic history traversal.
internal/app/azldev/cmds/component/render.go Create render staging directories under the project work dir to avoid filling /tmp.

Comment thread internal/app/azldev/cmds/component/render.go Outdated
Comment thread internal/app/azldev/cmds/component/update.go Outdated
Comment thread internal/app/azldev/core/sources/synthistory.go
Co-authored-by: Copilot <copilot@github.com>
@dmcilvaney dmcilvaney merged commit 9bf2032 into microsoft:main Apr 30, 2026
15 checks passed
@dmcilvaney dmcilvaney deleted the damcilva/integrate_new_distgit branch April 30, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants