fix(render): Scrub submodules from distgits#137
Merged
dmcilvaney merged 3 commits intomicrosoft:mainfrom Apr 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR aims to prevent go-git operations from failing when dist-git repositories contain orphaned/bogus submodule (“gitlink”) entries by scrubbing those entries from the git index before staging/committing.
Changes:
- Add
removeSubmoduleEntriesto strip160000(submodule) entries from the index and delete corresponding directories. - Invoke submodule scrubbing during synthetic-history preparation.
- Add unit tests covering submodule stripping and no-op cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/app/azldev/core/sources/sourceprep.go | Adds and wires in index-scrubbing logic for submodule (gitlink) entries before staging. |
| internal/app/azldev/core/sources/sourceprep_internal_test.go | Adds tests validating index scrubbing and directory cleanup behavior. |
dmcilvaney
force-pushed
the
damcilva/fix_prep_src_git_submodules
branch
from
e5ae5c2 to
a5e3a2d
Compare
Co-authored-by: Copilot <copilot@github.com>
reubeno
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various git operations get confused when there are orphaned git submodules in the distgit, scrub them out.