Skip to content

Python: fix: inject synthetic tool results for pending frontend tool calls#4935

Open
ranst91 wants to merge 1 commit intomicrosoft:mainfrom
ranst91:fix/tool-results-for-pendind-tool-calls
Open

Python: fix: inject synthetic tool results for pending frontend tool calls#4935
ranst91 wants to merge 1 commit intomicrosoft:mainfrom
ranst91:fix/tool-results-for-pendind-tool-calls

Conversation

@ranst91
Copy link

@ranst91 ranst91 commented Mar 26, 2026

Description

When an agent calls a declaration-only (frontend/client-side) tool — such as
a generative UI component like pieChart — and the conversation ends without
a user message following, the tool call remains "pending" in the message
history with no corresponding tool result.

On the next request, OpenAI rejects the conversation with a 400 error:
"An assistant message with 'tool_calls' must be followed by tool messages
responding to each 'tool_call_id'."

_sanitize_tool_history already handles this when a user message arrives while
calls are pending — it injects synthetic results before the user turn. This
fix extends that logic to also cover the end-of-messages case, so pending
tool calls are always resolved before the history is sent to OpenAI.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings March 26, 2026 16:52
@github-actions github-actions bot changed the title fix: inject synthetic tool results for pending frontend tool calls Python: fix: inject synthetic tool results for pending frontend tool calls Mar 26, 2026
@microsoft-github-policy-service

@ranst91 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends AG-UI message sanitization so that when a conversation ends with an assistant tool_calls message (common for declaration-only/frontend tools), synthetic tool results are injected to prevent OpenAI from rejecting the next request due to unmatched tool_call_ids.

Changes:

  • Inject synthetic role="tool" function_result messages when the message list ends with pending tool calls.
  • Add logging to indicate pending tool calls were resolved via synthetic results.

Comment on lines +197 to +215
# If the conversation ends with pending tool calls (e.g. a declaration-only
# frontend tool was called with no user message following), inject synthetic
# results so the next OpenAI call doesn't get a 400 for unmatched tool_call_ids.
if pending_tool_call_ids:
logger.info(
f"Messages ended with {len(pending_tool_call_ids)} pending tool calls - "
"injecting synthetic results"
)
for pending_call_id in pending_tool_call_ids:
logger.info(f"Injecting synthetic tool result for pending call_id={pending_call_id}")
sanitized.append(Message(
role="tool",
contents=[
Content.from_function_result(
call_id=pending_call_id,
result="Tool execution skipped - frontend tool result not yet received",
)
],
))
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Injecting a synthetic tool result at the end will cause any later real tool result for the same call_id (arriving in a subsequent request) to be treated as unmatched and dropped by _sanitize_tool_history (the synthetic result clears pending_tool_call_ids before the real tool message is processed). If frontend tools can legitimately return results asynchronously, consider limiting this end-of-history injection to tools known to be result-less (declaration-only), or adjust the sanitization logic to prefer/replace the synthetic placeholder when a real tool result is later received.

Copilot uses AI. Check for mistakes.
Comment on lines +197 to 217
# If the conversation ends with pending tool calls (e.g. a declaration-only
# frontend tool was called with no user message following), inject synthetic
# results so the next OpenAI call doesn't get a 400 for unmatched tool_call_ids.
if pending_tool_call_ids:
logger.info(
f"Messages ended with {len(pending_tool_call_ids)} pending tool calls - "
"injecting synthetic results"
)
for pending_call_id in pending_tool_call_ids:
logger.info(f"Injecting synthetic tool result for pending call_id={pending_call_id}")
sanitized.append(Message(
role="tool",
contents=[
Content.from_function_result(
call_id=pending_call_id,
result="Tool execution skipped - frontend tool result not yet received",
)
],
))

return sanitized
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds new behavior for the "assistant tool_calls at end of history" case, but there isn't a regression test covering it. Please add a unit test that passes [assistant(tool_call)] with no following user/tool message and asserts a synthetic role="tool" function_result is appended for the call_id.

Copilot uses AI. Check for mistakes.
@moonbox3
Copy link
Contributor

Could you let us know, please, which version of agent-framework-ag-ui you're using?

@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
packages/ag-ui/agent_framework_ag_ui
   _message_adapters.py6025990%102–103, 112–115, 118–122, 124–129, 132, 141–147, 187, 201, 205–207, 338, 428–431, 433–435, 482–484, 538, 541, 543, 546, 549, 565, 582, 604, 704, 720–721, 792, 814, 884, 919–920, 988, 1031
TOTAL28017341687% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
5454 20 💤 0 ❌ 0 🔥 1m 29s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants