Python: fix: add to_json to Content for serialization compatibility#4721
Open
jnMetaCode wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: fix: add to_json to Content for serialization compatibility#4721jnMetaCode wants to merge 1 commit intomicrosoft:mainfrom
jnMetaCode wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Content has to_dict() but lacks to_json(), causing TypeError when Azure Functions serializes Message objects containing Content instances. Add to_json() matching the pattern used by SerializationMixin. Fixes microsoft#4719 Signed-off-by: JiangNan <1394485448@qq.com>
github-actions
bot
changed the title
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_json()method to theContentclass, fixingTypeErrorwhen Azure Functions serializesMessageobjects containingContentinstances.Contentalready hasto_dict()but lacked the correspondingto_json()thatSerializationMixinprovides. This adds it following the same pattern: delegates tojson.dumps(self.to_dict()).Fixes #4719
Test plan
Content.from_text("hello").to_json()returns valid JSONto_json(indent=2))exclude_noneandexcludeparameters work as expected