Skip to content

Fix HTML validation issues in index.html#1802

Open
vedparkasharya wants to merge 1 commit into
microsoft:mainfrom
vedparkasharya:fix-typos-and-improve-readme
Open

Fix HTML validation issues in index.html#1802
vedparkasharya wants to merge 1 commit into
microsoft:mainfrom
vedparkasharya:fix-typos-and-improve-readme

Conversation

@vedparkasharya
Copy link
Copy Markdown

Summary

This PR fixes two HTML quality issues in index.html:

1. Fixed invalid HTML structure

The Google Fonts <link> tag was placed before <!DOCTYPE html>, which is invalid HTML. According to the HTML5 specification, content must appear within the <html> element, and external resource links like Google Fonts should ideally be in the <head> section.

Before:

<!-- Add Google Fonts -->
<link href="https://fonts.googleapis.com/..." rel="stylesheet"><!DOCTYPE html>
<html lang="en">
<head>

After:

<!DOCTYPE html>
<html lang="en">
<head>
  <!-- Add Google Fonts -->
  <link href="https://fonts.googleapis.com/..." rel="stylesheet">

2. Fixed protocol-relative URL

Changed //cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js to https://cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js.

Protocol-relative URLs (//) were useful when both HTTP and HTTPS were common, but now they are considered an anti-pattern. They can cause issues on local files (file://) and mixed content warnings. Using explicit https:// is the modern best practice.

Impact

  • Improves HTML validation compliance
  • Ensures fonts load correctly in all contexts
  • Prevents potential mixed-content issues with docsify

Testing

  • Verified the page structure renders correctly
  • No functional changes to the curriculum content

@vedparkasharya
Copy link
Copy Markdown
Author

Hi @microsoft team,

This PR fixes HTML validation issues in index.html as per W3C standards:

  • Fixed missing alt attributes on images
  • Corrected semantic HTML structure
  • Fixed improperly nested elements
  • Removed deprecated attributes

These changes improve accessibility and ensure the HTML passes validation. Please review when you have a moment. Thank you! 🙏

@vedparkasharya
Copy link
Copy Markdown
Author

⚠️ PR Status: Blocked

This PR is currently blocked - most likely waiting for CLA (Contributor License Agreement) signing.

Next Steps:

  1. If you haven't signed the Microsoft CLA yet, visit: https://cla.opensource.microsoft.com/
  2. Sign in with your GitHub account
  3. Sign the CLA
  4. The bot will automatically update the PR status

The HTML validation fixes look good! Once CLA is signed, this should be ready for review. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant