Fix optional property quick info showing redundant '| undefined'#62084
Open
sw1tch3roo wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix optional property quick info showing redundant '| undefined'#62084sw1tch3roo wants to merge 2 commits intomicrosoft:mainfrom
sw1tch3roo wants to merge 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
sw1tch3roo
force-pushed
the
fix/optional-property-quickinfo-consistency
branch
from
0ab5c4a to
d4b6731
Compare
DanielRosenwasser
requested changes
Jul 23, 2025
Member
There was a problem hiding this comment.
I don't think this is the change I had in mind (or at least, it's not testing the right stuff). The specific thing I'm bringing up is about hovering over Options itself when hover verbosity is enabled. It's not about quick info on accesses of specific properties.
While it's true that I think we should only show ? and not introduce the undefined type in these cases, you'll notice on the issue that the property border has a strangely different type compared to color.
github-project-automation
bot
moved this from Not started
to Waiting on author
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61954